Browse Source

[tasks] Clean up param names and loggin

Colin Powell 1 month ago
parent
commit
bf7d2514f2

+ 4 - 4
vrobbler/apps/scrobbles/scrobblers.py

@@ -409,9 +409,9 @@ def todoist_scrobble_task(
     user_id: int,
     started: bool = False,
     stopped: bool = False,
-    context_list: list[str] = [],
+    user_context_list: list[str] = [],
 ) -> Scrobble:
-    title = get_title_from_labels(todoist_task.get("todoist_label_list", []), context_list)
+    title = get_title_from_labels(todoist_task.get("todoist_label_list", []), user_context_list)
     task = Task.find_or_create(title)
 
     timestamp = pendulum.parse(todoist_task.get("updated_at", timezone.now()))
@@ -533,10 +533,10 @@ def emacs_scrobble_task(
     user_id: int,
     started: bool = False,
     stopped: bool = False,
-    context_list: list[str] = [],
+    user_context_list: list[str] = [],
 ) -> Scrobble | None:
     source_id = task_data.get("source_id")
-    title = get_title_from_labels(task_data.get("labels", []), context_list)
+    title = get_title_from_labels(task_data.get("labels", []), user_context_list)
 
     task = Task.find_or_create(title)
 

+ 2 - 2
vrobbler/apps/tasks/utils.py

@@ -14,7 +14,7 @@ def get_title_from_labels(labels: list[str], user_context_labels: list[str] = []
 
     if title == "Unknown":
         logger.warning(
-            "Missing a prefix and suffix tag for task",
-            extra={"labels": labels},
+            "Missing a configured title context for task",
+            extra={"labels": labels, "task_context_labels": task_context_labels},
         )
     return title

+ 2 - 2
vrobbler/apps/tasks/webhooks.py

@@ -100,7 +100,7 @@ def todoist_webhook(request):
             todoist_task,
             user_profile.user_id,
             stopped=task_stopped,
-            context_list=user_profile.task_context_tags,
+            user_context_list=user_profile.task_context_tags,
         )
 
     if todoist_note:
@@ -153,7 +153,7 @@ def emacs_webhook(request):
             user_id,
             started=task_in_progress,
             stopped=task_stopped,
-            context_list=user_profile.task_context_tags,
+            user_context_list=user_profile.task_context_tags,
         )
 
     if not scrobble: