Explorar el Código

Fix progress for books with no scrobbles

Colin Powell hace 2 años
padre
commit
34a6ac192d
Se han modificado 2 ficheros con 4 adiciones y 5 borrados
  1. 4 1
      vrobbler/apps/books/models.py
  2. 0 4
      vrobbler/apps/books/openlibrary.py

+ 4 - 1
vrobbler/apps/books/models.py

@@ -160,7 +160,10 @@ class Book(LongPlayScrobblableMixin):
         """Used to keep track of whether the book is complete or not"""
         user = User.objects.get(id=user_id)
         last_scrobble = get_scrobbles_for_media(self, user).last()
-        return int((last_scrobble.book_pages_read / self.pages) * 100)
+        progress = 0
+        if last_scrobble:
+            progress = int((last_scrobble.book_pages_read / self.pages) * 100)
+        return progress
 
     @classmethod
     def find_or_create(cls, data_dict: dict) -> "Game":

+ 0 - 4
vrobbler/apps/books/openlibrary.py

@@ -72,10 +72,6 @@ def lookup_book_from_openlibrary(title: str, author: str = None) -> dict:
         return {}
 
     top = results.get("docs")[0]
-    if author and author not in top["author_name"]:
-        logger.warn(
-            f"Lookup for {title} found top result with mismatched author"
-        )
     ol_id = top.get("cover_edition_key")
     ol_author_id = get_first("author_key", top)
     first_sentence = ""